TeamNewPipe/NewPipe

CommentRepliesSource: Add cache for reply fetching

Open

#11,718 opened on Nov 18, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (38,153 stars) (3,577 forks)batch import
bugcommentshelp wantedrewrite

Description

There is no cache in the comment replies fetching, causing the app to reload them each time the device is rotated or a switch between the description content view tab and the comments one is done. This regression must be fixed.

Originally posted by @AudricV in https://github.com/TeamNewPipe/NewPipe/pull/11060#discussion_r1836886664

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaAndroid developmentCaching concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Locate the CommentRepliesSource class in the NewPipe codebase (likely in app/src/main/java/org/schabi/newpipe/...). Understand how replies are currently fetched and where caching can be added (e.g., using LruCache or a simple Map). Ensure the cache is invalidated appropriately when new comments are loaded. Check the linked PR (https://github.com/TeamNewPipe/NewPipe/pull/11060) and the discussion for context and possible implementation hints. After implementing, test on device rotation and tab switching to confirm no unnecessary reloads.