TeamNewPipe/NewPipe

CommentRepliesSource: Add cache for reply fetching

Open

#11,718 opened on Nov 18, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (3,577 forks)batch import
bugcommentshelp wantedrewrite

Repository metrics

Stars
 (38,153 stars)
PR merge metrics
 (Avg merge 9d 17h) (17 merged PRs in 30d)

Description

There is no cache in the comment replies fetching, causing the app to reload them each time the device is rotated or a switch between the description content view tab and the comments one is done. This regression must be fixed.

Originally posted by @AudricV in https://github.com/TeamNewPipe/NewPipe/pull/11060#discussion_r1836886664

Contributor guide

Research direction
Investigate the current reply fetching logic and implement a caching layer (e.g., using in memory cache or shared preferences) to avoid reloading data on rotation or tab switch.
Tech stack
java
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70