TandoorRecipes/recipes

Richer reverse proxy authentication

Open

#1134 opened on Dec 13, 2021

View on GitHub
 (6 comments) (3 reactions) (0 assignees)HTML (4,470 stars) (500 forks)batch import
enhancementgood first issueinfrastructure

Description

Is your feature request related to a problem? Please describe.

Being able to use Authelia SSO without much fuss is great, but unfortunately the only piece of user information that recipes grabs right now is the HTTP_REMOTE_USER, which makes it hard to use the built in invite system!

Furthermore, the logout link is hard coded and cannot be overridden with an environment variable. This prevents being able to use an SSO logout url e.g. https://authelia.example.com/logout

Describe the solution you'd like

  1. Add support for other header fields like:
  • HTTP_REMOTE_NAME
  • HTTP_REMOTE_EMAIL

  1. Update this information as required when a user logs in e.g. their email address has changed.

  2. Add an environmental variable REVERSE_PROXY_AUTH_LOGOUT to specify a custom logout URL.

Describe alternatives you've considered I guess I could manage users in Recipes as well as in Authelia, but that means double-handling of information for my use case.

Contributor guide

Tech stack
pythondjango
Domain
backendauthentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Django authenticationreverse proxy configurationenvironment variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the current reverse proxy authentication implementation in the codebase, likely in `recipes/` or `cookbook/` directories. Look for how HTTP REMOTE USER is currently handled and where environment variables are loaded. Check comments #1134 for additional user suggestions. Consider adding a middleware or modifying existing authentication backend to read additional headers and an environment variable for logout URL.