TIBCOSoftware/flogo

Remove the `value` output param from Lambda Invoke activity

Open

#410 opened on Oct 15, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)CSS (2,348 stars) (290 forks)batch import
good first issuekind/enhancement

Description

Current behavior (how does the issue manifest): The lambda invoke activity returns a value object which includes the payload and the []byte serialized response. This really has no real purpose and causes confusion between the unmarshaled payload in the return param result .

Expected behavior: Remove the value param, as both the unmarshaled payload and the status are both returned in separate params already, no need to keep a struct of the raw return data.

Minimal steps to reproduce the problem (not required if feature enhancement):

Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X

Additional information you deem important (e.g. issue happens only occasionally):

Contributor guide

Tech stack
go
Domain
backendcloud
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingFlogo activity conceptsAWS Lambda invoke basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Locate the Lambda Invoke activity source code in the Flogo repository, typically under /contrib/activity/lambda. Identify where the `value` output parameter is defined, likely in the activity's metadata or result struct. Remove this parameter and update any references to it in the activity implementation. Ensure that the `result` parameter and status are still correctly returned. Since there are no comments or linked PRs, review the current code for any downstream dependencies on `value`. No tests are mentioned, but verify that the change does not break existing functionality.