TIBCOSoftware/flogo

Inference Activity: Should check if *pb OR *pbtxt exist

Open

#354 opened on Aug 27, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)CSS (2,348 stars) (290 forks)batch import
good first issuekind/enhancementmachine-learning

Description

Current behavior (how does the issue manifest): Currently only saved_model.pb is checked to see if it is opened.

Expected behavior: We should check if saved_model.pbtxt exists too.

Minimal steps to reproduce the problem (not required if feature enhancement):

Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):

Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X

Additional information you deem important (e.g. issue happens only occasionally):

Contributor guide

Tech stack
go
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Go knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the inference activity code in the flogo repository (likely in a directory such as 'activity/inference'). Find where 'saved model.pb' is checked for existence (e.g., using os.Stat or similar). Add an additional check for 'saved model.pbtxt' using the same pattern. Ensure the code handles both file types gracefully.