SynthstromAudible/DelugeFirmware

Metronome is always on during count-in and unable to be toggled off

Open

#3,250 opened on Jan 9, 2025

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)C++ (165 forks)auto 404
good first issue

Repository metrics

Stars
 (669 stars)
PR merge metrics
 (Avg merge 2d 19h) (58 merged PRs in 30d)

Description

Please describe the problem:

The recording count-in (engaged by pressing rec then play) is always accompanied by an audible metronome, regardless of whether the metronome is toggled on or not (shift + tap tempo)

Furthermore, the metronome can not be toggled off during the count-in (via shift + tap tempo) as the 1.2 changelog would suggest (even though that was fixed in #2653)

What is the expected behavior?

If the metronome is off in general then the count-in should be silent

Also if the metronome is on during count-in you should be able to toggle it off using shift + tap tempo (as per #2653)

When did you start noticing the issue?

I first noticed it on 2025-01-08 using the 1.2 release

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

7SEG

What firmware did you reproduce it with?

Release 1.2/Chopin

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

https://github.com/user-attachments/assets/7d951d1e-a92b-448d-b5cd-2dc1d19120d0

Contributor guide

Research direction
Examine the count in logic and metronome toggle handling. Look at the previous fix (#2653) and trace why toggling off fails. Inspect code paths for count in and metronome state.
Tech stack
cpp
Domain
embedded iot
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75