Swinject/Swinject

GraphStorage optimization

Open

#373 opened on Sep 18, 2018

View on GitHub
 (0 comments) (3 reactions) (0 assignees)Swift (465 forks)batch import
bughelp wanted

Repository metrics

Stars
 (5,745 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When underlying value wrapped in the Weak container is released, entry in the GraphStorage.instances will remain.

We should optimise this - probably by actively checking and removing empty Weak wrappers during storage's lifetime.

Contributor guide

Research direction
Inspect the Weak wrapper class and the instances dictionary in GraphStorage. Add logic to remove entries with nil references upon access or periodically.
Tech stack
swift
Domain
mobile
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70