Swinject/Swinject

GraphStorage optimization

Open

#373 opened on Sep 18, 2018

View on GitHub
 (0 comments) (3 reactions) (0 assignees)Swift (5,745 stars) (465 forks)batch import
bughelp wanted

Description

When underlying value wrapped in the Weak container is released, entry in the GraphStorage.instances will remain.

We should optimise this - probably by actively checking and removing empty Weak wrappers during storage's lifetime.

Contributor guide

Tech stack
swift
Domain
backendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftWeak reference concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the GraphStorage and InstanceStorage implementations, specifically the `instances` dictionary and the `Weak` container. Investigate when and how empty `Weak` wrappers accumulate, and design a strategy to remove them efficiently (e.g., during access or on a timer). Consider thread safety implications.
GraphStorage optimization · Swinject/Swinject#373 | Good First Issue