SwiftKickMobile/SwiftMessages

window being accessed from background thread when dequeueNext is called

Open

#535 opened on Nov 14, 2023

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Swift (754 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,449 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

dequeueNext is being called from a background queue here.

This in turn does a check to the isOrphaned property here.

The isOrphaned property does a check to the view.window property here.

This triggers an XCode warning with "UIView.window must be used from main thread only". This can lead to possible crashes.

Contributor guide

Research direction
Ensure that `dequeueNext` is dispatched to the main queue before accessing `view.window` or make `isOrphaned` thread safe by checking the window on the main thread.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
swiftuikitmultithreading
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60