SwiftKickMobile/SwiftMessages

Xcode warnings in two swift files

Open

#534 opened on Nov 10, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (754 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,449 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug I have received the following warnings in Xcode for SwiftMessages package (the numbers in brackets indicate the frequency):

BaseView.swift:

(2) Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

SwiftMessagesSegue.swift:

(1) Unnecessary check for 'iOS'; enclosing scope ensures guard will always be true

Environment (please complete the following information):

  • Xcode version: Xcode 15.0
  • SwiftMessages Versions: v9.0.6, v9.0.9
  • Device: iPhone7
  • Simulator: iPhone15
  • OS: iOS 15+

Contributor guide

Research direction
Open the SwiftMessages package in Xcode, navigate to BaseView.swift and SwiftMessagesSegue.swift, and address the compiler warnings: for BaseView.swift, change the override of a non '@objc' method to use 'public' instead; for SwiftMessagesSegue.swift, remove the unnecessary iOS version check.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Xcode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90