Supervisor/supervisor

I/O operation on closed file

Open

#984 opened on Aug 24, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (1,233 forks)batch import
help wantedlogging

Repository metrics

Stars
 (7,941 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello.

Using supervisor 3.3.3 on OS X, installed through brew.

The system seems to work 'ok'; but the error file is a torrent of errors such as these (below). Any hints appreciated.

2017-08-24 13:34:04,513 CRIT uncaptured python exception, closing channel <POutputDispatcher at 4318273408 for <Subprocess at 4316929848 with name central-worker-engine-2 in state RUNNING> (stdout)> (<type 'exceptions.ValueError'>:I/O operation on closed file [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/supervisord.py|runforever|227] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/dispatchers.py|handle_read_event|232] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/dispatchers.py|record_output|166] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/dispatchers.py|_log|142] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/loggers.py|info|275] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/loggers.py|log|293] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/loggers.py|emit|186] [/usr/local/Cellar/supervisor/3.3.3/libexec/lib/python2.7/site-packages/supervisor/loggers.py|doRollover|211])

Contributor guide

Research direction
Investigate the race condition where log file rotation closes the file descriptor while output is being written, leading to 'I/O operation on closed file'. Look at dispatchers.py and loggers.py for synchronization issues.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70