Supervisor/supervisor

Eventlistener protocol "len" header changed in Supervisor 4

Open

#1243 opened on May 23, 2019

View on GitHub
 (33 comments) (0 reactions) (0 assignees)Python (7,941 stars) (1,233 forks)batch import
eventshelp wanted

Description

@plockaby wrote comments of issue #1235:

Migrating from version 3 to version 4, my event listeners read from supervisor over stdin using a byte stream and then did the conversion to utf8 and chose to "backslashreplace" undecodable utf8 data. When I went to version 4 I expected to continue to get a byte stream that I could convert myself to whatever encoding I knew the data to be in. It was really unexpected to discover that supervisor was doing the conversion for me and then telling me the number of characters to read off of stdin and not the number of bytes.

cc: @vsajip

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of PythonUnderstanding of Supervisor event listener protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the change in the 'len' header from bytes to characters in Supervisor's event listener protocol. Review the pull request discussion at PR #1235 and the referenced issue #1235. Look at the supervisor/events.py or similar files where stdin reading and header parsing occurs. Determine if the conversion to characters is intentional or a bug, and consider adding a configuration option to preserve byte based behavior.