StackStorm/st2

Add tests for all linux pack actions

Open

#4,999 opened on Jul 20, 2020

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (740 forks)batch import
bugcomplexity:easygood first issuepackstests

Repository metrics

Stars
 (5,794 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The contrib linux pack has a few broken actions (check_loadavg, check_processes, dig: #4993, diag_loadavg, netstat: #4947, possibly more) at least on CentOS 8. It's really disheartening to spin up StackStorm and immediately run into broken actions.

We should add tests for those actions to the pack.

The tests from the core pack can be used as a template for writing tests for the linux pack.

I will try to add tests for the dig action in my PR #4993, to serve as a concrete example, but adding tests would be a useful way to introduce somebody to developing StackStorm that would have an immediate impact.

Contributor guide

Research direction
Examine the existing tests in the core pack, then write similar tests for the linux pack actions, focusing on the broken actions listed in the issue.
Tech stack
python
Domain
testingbackenddevops
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70