StackStorm/st2

Add tests for all linux pack actions

Open

#4999 opened on Jul 20, 2020

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Python (5,794 stars) (740 forks)batch import
bugcomplexity:easygood first issuepackstests

Description

The contrib linux pack has a few broken actions (check_loadavg, check_processes, dig: #4993, diag_loadavg, netstat: #4947, possibly more) at least on CentOS 8. It's really disheartening to spin up StackStorm and immediately run into broken actions.

We should add tests for those actions to the pack.

The tests from the core pack can be used as a template for writing tests for the linux pack.

I will try to add tests for the dig action in my PR #4993, to serve as a concrete example, but adding tests would be a useful way to introduce somebody to developing StackStorm that would have an immediate impact.

Contributor guide

Tech stack
pythonshell
Domain
testingbackend
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python testing basicsStackStorm pack structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the existing tests in contrib/core/tests as a template. Examine the broken actions (check loadavg, check processes, dig, diag loadavg, netstat) and their current behavior on CentOS 8. PR #4993 provides an example for the dig action. Write similar tests for each action, focusing on verifying expected outputs and error handling.