StackStorm/st2

SSH connect timeout is too long (60s)

Open

#4,715 opened on Jun 20, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Python (5,794 stars) (740 forks)batch import
enhancementgood first issuerunners

Description

The st2 ssh connect timeout in st2 ssh_runner is 60s and it is not configurable. It is too long - the ansibile default is 10s.

We better make it configurable and give it a more suitable default value.

Contributor guide

Tech stack
python
Domain
backenddevops
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python basicsUnderstanding of SSH configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the st2 ssh runner code in the st2 repository, likely in st2/st2common/ssh/ssh runner.py or similar, to find where the 60s timeout is hardcoded. Then add a configurable option (e.g., via st2.conf or environment variable) and change the default to 10s. Follow existing configuration patterns in the codebase.