`st2 pack install` will ignore failures when installing multiple packs · StackStorm/st2#4620

(2 comments) (0 reactions) (0 assignees)Python (5,794 stars) (740 forks)batch import

CLIbugcomplexity:easygood first issue

Description

SUMMARY

If I attempt to install multiple packs using st2 pack install, and one of those packs is non-existent, it will silently ignore the failure.

ISSUE TYPE

Bug Report

STACKSTORM VERSION

st2 3.0dev (d86747c), on Python 2.7.12

OS / ENVIRONMENT / INSTALL METHOD

one-line install.

STEPS TO REPRODUCE

extreme@ubuntu:~$ st2 pack install foobar acos

For the "foobar, acos" packs, the following content will be registered:

rules     |  0
sensors   |  0
aliases   |  0
actions   |  19
triggers  |  0

Installation may take a while for packs with many items.

	[ succeeded ] download pack
	[ succeeded ] make a prerun
	[ succeeded ] install pack dependencies
	[ succeeded ] register pack

+-------------+-----------------------------------------------+
| Property    | Value                                         |
+-------------+-----------------------------------------------+
| name        | acos                                          |
| description | Manage ACOS-based appliances of A10 Networks. |
| version     | 0.2.5                                         |
| author      | Hiroyasu OHYAMA                               |
+-------------+-----------------------------------------------+
extreme@ubuntu:~$

EXPECTED RESULTS

I expected some error message about "pack foobar not found", similar to if I had just tried st2 pack install foobar

ACTUAL RESULTS

Install completes 'successfully', since one pack install works.

Contributor guide

Tech stack: pythonshell
Domain: backendcli
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: stale
Clarity: clear
Prerequisites: Basic understanding of PythonFamiliarity with CLI toolsStackStorm pack installation flow
Newbie friendliness: 40
Research direction: Investigate the pack installation logic in the StackStorm codebase. Focus on the 'st2 pack install' command handler, likely in `st2actions/st2actions/pack install.py` or similar. The issue is that when installing multiple packs, failures from individual pack installations are not aggregated or reported. Look at how the command handles multiple pack names and how it reports success/failure. Consider modifying the code to return a non zero exit code and an error message when one or more packs fail.