StackStorm/st2

Retry logic for 'st2client' and 'st2 pack'

Open

#3,257 opened on Feb 27, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (740 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,794 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Improvement from the https://github.com/StackStorm/st2-packages/issues/429

Most of the networking-related logic needs retrying mechanism. This is a rule of dumb in any package manager/client since in reality failures occur pretty frequently.

StackStorm shouldn't be an exception in following more reliable strategy.

TODO

  1. Add retry, timeout, delay-on-retry logic to st2client httpclient
  2. st2 pack retry logic for git cloning and any networking-related requests.

Resources

Contributor guide

Research direction
Implement retry logic with exponential backoff in st2client's HTTP client using requests adapters, and add similar retry mechanisms for git cloning and networking calls in st2 pack.
Tech stack
python
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonrequests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65