StackStorm/st2

`st2-self-check` fails on older st2 versions

Open

#3095 opened on Dec 5, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Python (5,794 stars) (740 forks)batch import
buggood first issuetests

Description

We YOLO-pull st2tests master in st2-self-check script. This makes script broken on older st2 versions.

So st2-self-check should rely on versioned branches in st2tests.

TODO: Parse https://github.com/StackStorm/st2/blob/master/st2common/st2common/__init__.py to determine the correct git vX.Y branch to get.

Contributor guide

Tech stack
pythonshell
Domain
devopsci cd
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python basicsShell scriptingGit branching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
First, locate the `st2 self check` script at `st2common/bin/st2 self check` and examine the line that pulls `st2tests` master (line 64). Then, look at `st2common/st2common/ init .py` to find how the version is defined (e.g., ` version `). The fix involves modifying the script to parse that version, construct a branch name like `vX.Y`, and use it to clone the appropriate `st2tests` branch. Test the change with both a recent and older version of st2 to ensure the script works correctly.