StackStorm/st2

Unit Tests for Actions in `packs` pack

Open

#3057 opened on Nov 28, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (5,794 stars) (740 forks)batch import
enhancementgood first issuetests

Description

Following the ChatOps Aliases Tests, write Pack Unit Tests for packs Actions (https://github.com/StackStorm/st2/pull/2982):

See: https://github.com/StackStorm/st2/tree/master/contrib/packs/actions

  • packs.delete
  • packs.download
  • packs.get
  • packs.get_config
  • packs.load
  • packs.search
  • packs.setup_virtualenv
  • packs.show
  • packs.unload
  • packs.update_virtualenv
  • packs.virtualenv_prerun

Not going to do tests for these: * [ ] packs.restart_component (it's just a local-shell-cmd) * [ ] packs.uninstall - it's a chain calling delete/unload * [ ] packs.install it's a chain calling download/virtualenv_prerun/setup_virtualenv/load

Contributor guide

Tech stack
python
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonunit testingpacks actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the existing unit tests for ChatOps Aliases (issue #3056) and the packs actions directory at contrib/packs/actions. Focus on implementing tests for the unchecked items: packs.load, packs.setup virtualenv, packs.update virtualenv, packs.virtualenv prerun. Follow the Pack Unit Testing documentation at https://docs.stackstorm.com/development/pack testing.html and refer to the structure of already completed tests (e.g., packs.delete, packs.download) as a pattern.