Incomplete next staged concurrent task with items if last running nested item fails.

Open
#222 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with the workflow in the issue and reproduce the failure where Nested6 runs with concurrency 1 and the last item fails. Review the TASK_STATE_MACHINE_DATA transition described in PR #221, then verify that subsequent staged items are executed after a nested task failure and that the staged task is not marked complete prematurely.

Written by the indexing model from the issue text.

Description

The below workflow didn't execute Nested6 for subsequent items in listed, if it fails for any item in listed. Basically if last running concurrent nested task is failed than it marks the staged task as completed and didn't pick the next task from staged items.

I have proposed a change which worked for me in a PR https://github.com/StackStorm/orquesta/pull/221. Where I have update the TASK_STATE_MACHINE_DATA map for current state to new state for event events.ACTION_FAILED_TASK_DORMANT_ITEMS_INCOMPLETE: statuses.RUNNING.

---
version: "1.0"
description: "Workflow desc"
input:
- "nested"
- "break_on"
- "l_c"
- "listed"
tasks:
  Start:
    action: "core.noop"
    next:
    - when: "<% succeeded() %>"
      do: "Nested6"

  Nested6:
    action: "core.local cmd='exit 1'"
    input:
      b: "<% item(list_i) %>"
      l_c: "<% ctx().l_c %>"
    next:
    - when: "<% succeeded() %>"
      do: "Join11"
    - when: "<% failed() %>"
      do: "Join12"
    with:
      items: list_i in <% ctx(listed) %>
      concurrency: 1

  Join11:
    action: "core.noop"
    next:
    - when: "<% failed() %>"
      do: "fail"
    join: "all"
  Join12:
    action: "core.noop"
    next:
    - when: "<% failed() %>"
      do: "fail"
    join: "all"
Dominant language
Python
Stars
111
Forks
44
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from StackStorm/orquesta

All issues in StackStorm/orquesta

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.