Ensure conditional hover/focus classes override conditional dark mode classes

Open
#815 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
css
Domain
design, frontend

Research direction

No file or test is named. Start by reproducing the provided button markup and tracing how conditional dark-mode, hover, and focus classes are generated and ordered. Done means hover and focus styles take precedence over dark-mode styles while the other conditional styling remains intact.

Written by the indexing model from the issue text.

Description

bug dark-mode

Current behavior: When an element has a conditional dark mode class and a conditional hover or focus class, the dark mode styling overrides the hover style.

Desired behavior: Hover/focus styling should apply over dark mode styling when hovering.

This was prompted by an issue encountered with this markup:

<button id="js-dismiss-articles-btn" class="s-btn fc-black-200 bg-black-600 bc-black-300 h:bg-black-700 d:bg-black-900" type="submit">*</button>
Dominant language
TypeScript
Stars
672
Forks
107
Avg merge
2d 12h
Merged PRs (30d)
26

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from StackExchange/Stacks

All issues in StackExchange/Stacks

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.