Squirrel/Squirrel.Windows

VersionExtensions Regex does not support package ID ending with numbers

Open

#472 opened on Oct 27, 2015

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (7,025 stars) (1,061 forks)batch import
bug:failing-test-would-be-nicehelp wanted

Description

Hi,

if you use NuGet Package Explorer and your nuget package id ends with a number updates won't work anymore (caused by changes in VersionExtensions.cs for prerelease support).

The NuGet Package Explorer uses a point to seperate the package id from the version number (at least if you don't change the filename).

ID: MyId123 Version: 1.1.0

The result would be "MyId123.1.1.0.nupkg"

The suffix regex will remove ".nupkg" and the version regex will match "123.1.1.0" instead of "1.1.0".

A workaround would be renaming your NuGet Package to "MyId123-1.1.0.nupkg". The code should be changed or this naming issue should be noted somewhere.

Contributor guide

Tech stack
csharp
Domain
desktoprelease
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# regexNuGet package namingVersionExtensions.csbasic Squirrel.Windows knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is in VersionExtensions.cs where the regex for extracting the version from the filename assumes the package ID does not end with digits. Examine the current regex pattern and modify it to correctly separate the ID and version, possibly by using a delimiter like a hyphen or by anchoring the version pattern. The workaround is to rename packages with a hyphen, but the fix should handle both formats. Check the comments for any further context.