Squirrel/Squirrel.Windows

During update and uninstall some unrelated shortcuts pinned to the taskbar may get updated

Open

#1,238 opened on Jan 23, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (7,025 stars) (1,061 forks)batch import
bug:failing-test-would-be-nicehelp wanted

Description

Two, or more applications with names that begin the same for example:

MyApp and MyAppTwo

If I have both the apps pinned on the taskbar and I update or uninstall MyApp the shortcuts of the other app MyAppTwo pinned to the taskbar will be updated too.

Could this be the issue? https://github.com/Squirrel/Squirrel.Windows/blob/b25c9fa1e4d60f8969137532a95bd53bb5a8de1f/src/Squirrel/UpdateManager.ApplyReleases.cs#L454

Contributor guide

Tech stack
csharp
Domain
desktoptooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Windows shell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the shortcut update logic in src/Squirrel/UpdateManager.ApplyReleases.cs around line 454 to understand how shortcuts are matched to applications. The issue suggests that the matching is based on name prefix, which causes false matches for similarly named apps. The fix should ensure exact matching or use additional identifiers (like app ID) to avoid updating unrelated shortcuts. Look for comments or existing tests related to shortcut management.