Squirrel/Squirrel.Windows

During update and uninstall some unrelated shortcuts pinned to the taskbar may get updated

Open

#1,238 opened on Jan 23, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (1,061 forks)batch import
bug:failing-test-would-be-nicehelp wanted

Repository metrics

Stars
 (7,025 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Two, or more applications with names that begin the same for example:

MyApp and MyAppTwo

If I have both the apps pinned on the taskbar and I update or uninstall MyApp the shortcuts of the other app MyAppTwo pinned to the taskbar will be updated too.

Could this be the issue? https://github.com/Squirrel/Squirrel.Windows/blob/b25c9fa1e4d60f8969137532a95bd53bb5a8de1f/src/Squirrel/UpdateManager.ApplyReleases.cs#L454

Contributor guide

Research direction
Investigate the shortcut update logic in UpdateManager.ApplyReleases.cs around line 454. The issue is that when comparing shortcuts by name, a naive string comparison matches partial names (e.g., "MyApp" matches "MyAppTwo"). Look for how shortcut identifiers are compared and consider using exact matching or separating by a delimiter.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Windows developmentC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40