FTS 's issues MEGA THREAD

Open
#29 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Open webpack://Mashlib/node_modules/solid-ui/lib/widgets/dragAndDrop.js and inspect the dragenterListener and dragleaveListener behavior. Reproduce the drag interaction and determine when the element's border should persist. Done means the intended border styling remains correctly after dragenter without breaking the existing dragleave restoration behavior.

Written by the indexing model from the issue text.

Description

to somehow persist ele border draw on dragenter

webpack://Mashlib/node_modules/solid-ui/lib/widgets/dragAndDrop.js

`var dragenterListener = function dragenterListener(e) {
debug.log('dragenter event dropEffect: ' + e.dataTransfer.dropEffect);

if (this.style) {
  //  necessary not sure when
  if (!this.savedStyle) {
    this.savedStyle = {};
    this.savedStyle.border = this.style.border;
    this.savedStyle.backgroundColor = this.style.backgroundColor;
    this.savedStyle.borderRadius = this.style.borderRadius;
  }

  this.style.backgroundColor = '#ccc';
  this.style.border = '0.25em dashed black';
  this.style.borderRadius = '0.3em';
}

e.dataTransfer.dropEffect = 'link';
debug.log('dragenter event dropEffect 2: ' + e.dataTransfer.dropEffect);

};

var dragleaveListener = function dragleaveListener(e) {
debug.log('dragleave event dropEffect: ' + e.dataTransfer.dropEffect);

if (this.savedStyle) {
  this.style.border = this.savedStyle.border;
  this.style.backgroundColor = this.savedStyle.backgroundColor;
  this.style.borderRadius = this.savedStyle.borderRadius;
} else {
  this.style.backgroundColor = 'white';
  this.style.border = '0em solid black';
}

};`

Dominant language
JavaScript
Stars
7
Forks
3
Avg merge
7m
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SolidOS/issue-pane

All issues in SolidOS/issue-pane

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.