SimulatedGREG/electron-vue

console.log from main process doesn't print CJK characters

Open

#605 opened on May 4, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (15,445 stars) (1,586 forks)batch import
bughelp wanted

Description

"console.log" Chinese, Japanese in main process, cannot print.

Describe the issue / bug.

#

in "https://github.com/SimulatedGREG/electron-vue/tree/master/template/.electron-vue/dev-runner.js" line: 137


137: if (/[0-9A-z]+/.test(log)) {
   ....
}

log print english or number only.

Change


if (/[0-9A-z]+/.test(log)) {
   ....
}

to


if (log) {
   ....
}

or remove can fix it.

Contributor guide

Tech stack
javascriptvuenodejs
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is in the file `.electron vue/dev runner.js` at line 137. The current regex `/[0-9A z]+/` filters out CJK characters, so changing it to just check if `log` is truthy (e.g., `if (log)`) will allow printing of all characters. Alternatively, the regex could be updated to include Unicode ranges. There are 2 comments on the issue but no maintainer response or linked pull requests.