Simonwep/pickr

Broken on Safari 14

Open

#246 opened on Sep 23, 2020

View on GitHub
 (22 comments) (3 reactions) (0 assignees)JavaScript (4,037 stars) (281 forks)batch import
browser quirkhelp wanted

Description

What is the current behavior?

Save button doesn't function correctly and Button color not updating to reflect selection.

Please provide the steps to reproduce:

Use the demo https://simonwep.github.io/pickr/ on the latest version of Safari.

Your environment:

Version (see Pickr.version): 1.7.2
Used bundle (es5 or normal one): Both
Used theme (default is classic): All
Browser-version:  Safari 14.0 (15610.1.28.1.9, 15610)
Operating-system:  macOS 10.15.6 (19G2021)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptCross browser testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the event handlers for the 'Save' button and color selection updates in the main pickr.js file. The issue appears to be specific to Safari 14, so testing with BrowserStack or similar is recommended. Check the comments in the issue for any proposed fixes or workarounds from other users.