SigNoz/signoz

Handle request timeouts or 500 errors for getFilteredSpansAggregate API on frontend

Open

#919 opened on Mar 25, 2022

View on GitHub
 (12 comments) (0 reactions) (1 assignee)TypeScript (16,037 stars) (976 forks)batch import
frontendgood first issuehacktoberfest

Description

Bug description

When the backend API responds with 500 error code then the loader on charts section loads infinitely

Expected behavior

Charts should show No Data like in trace table.

Version information

  • Signoz version: 0.7.3

Thank you for your bug report – we love squashing them!

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptHTTP error handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the frontend code responsible for calling getFilteredSpansAggregate API. Look for where the API response is handled, likely in a service file or custom hook. Identify where the loading state is set and why it persists even when a 500 error occurs. Consider implementing a catch block or using a timeout to stop loading and display a 'No Data' state. Check existing error handling patterns in the codebase for consistency.