Spoom fails when a BUNDLE_PATH is set
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start at lib/spoom/context/exec.rb around line 36, where Spoom clears the Bundler environment and invokes bundle exec. Reproduce the problem with BUNDLE_PATH set and bundle exec spoom tc, then verify that the command can execute srb using the configured bundle without the missing-gems error.
Written by the indexing model from the issue text.
Description
Describe the bug
Spoom ignores the BUNDLE_PATH when trying to bundle exec srb.
To Reproduce
Spoom version: 1.2.4
Steps to reproduce the behavior:
- Set a BUNDLE_PATH
- Run
bundle exec spoom tc - You'll get an error along the lines of:
bundler: failed to load command: srb (/app/bundle/bin/srb)
/usr/local/lib/ruby/3.1.0/bundler/source/git.rb:214:in rescue in load_spec_files': https://github.com/crafterm/apnotic.git (at e0a84c9@e0a84c9) is not yet checked out. Run bundle install first. (Bundler::GitError)
The above error is from a Docker instance in our CI environment, with BUNDLE_PATH set to /app/bundle and spoom being executed in /app/api. The particular error will depend on your bundle path and gems, but it'll always tell you it can't find your gems and that you need to bundle install.
Expected behavior
Spoom should respect the BUNDLE_PATH and successfully execute srb.
The code
This code is what causes the problem. Spoom removes the entire bundler environment and then re-runs bundle exec.
I would expect Spoom and Sorbet to always be in the same bundle, so you shouldn't need to re-run bundle exec. Maybe there's a use case I'm not thinking of though?
- Dominant language
- Ruby
- Stars
- 272
- Forks
- 29
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Shopify/spoom
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 56/100
-
feature
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
user-reported
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kong/developer.konghq.com#7316 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
TheOdinProject/curriculum#31408 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
notch8/utk_knapsack#148 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Homebrew/homebrew-cask#288729 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100