Build dependency chain installs brace-expansion@2.1.2 affected by GHSA-mh99-v99m-4gvg
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- graphql, javascript, typescript
- Domain
- build-system, security
Research direction
Start with a clean checkout and run npm ci, then use npm explain minimatch --json, npm explain brace-expansion --json, and npm audit --json to trace the build dependency chain. Review the Shopify Function and graphql-config dependency ranges; done means the supported build dependencies resolve to an unaffected compatible minimatch/brace-expansion combination without an out-of-range consumer override.
Written by the indexing model from the issue text.
Description
Summary
The current Shopify Function JavaScript toolchain installs
brace-expansion@2.1.2 through minimatch@9.0.9. npm audit reports
GHSA-mh99-v99m-4gvg as high severity.
Environment and versions
- Node.js 24.13.1
- npm 11.8.0
- @shopify/shopify_function 2.0.1
- graphql-config 5.1.3
- minimatch 9.0.9
- brace-expansion 2.1.2
Reproduction
In a Shopify app with a JavaScript Function extension:
- Run
npm cifrom a clean checkout. - Run
npm explain minimatch --json. - Run
npm explain brace-expansion --json. - Run
npm audit --json.
The Function workspace reaches the affected package through the Shopify
Function/code-generation build chain, including graphql-config/minimatch.
The production app build was generated with:
npm exec --offline -- shopify app build --config production --no-color --skip-dependencies-installation
We checked the generated Function JavaScript and WASM with static byte/string
searches and found no minimatch, brace-expansion, or graphql-config package
reference. We therefore believe this is a build-tool dependency, but still
fail our dependency audit until it is resolved or narrowly reviewed.
Forcing minimatch 10 as a consumer override is not a safe workaround:
graphql-config 5.1.3 declares minimatch ^9.0.5, so npm reports the dependency
tree as invalid.
Expected result
The supported Function build dependencies should resolve to a minimatch /
brace-expansion combination that is not affected by
GHSA-mh99-v99m-4gvg.
The smallest preferred fix is a compatible Shopify Function dependency update
whose graphql-config/minimatch ranges support a patched brace-expansion
release, without requiring consumers to force an out-of-range major override.
Additional context
The package is used by the build toolchain and is not imported by the
generated Function JavaScript or WASM artifact in our verification. We are
still treating the audit result as fail-closed and would prefer an upstream
dependency update over an incompatible package override.
- Dominant language
- TypeScript
- Stars
- 35
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Shopify/shopify-function-javascript
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Shopify/shopify-function-javascript#127 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 25/100
Shopify/shopify-function-javascript#98 · 1 comment ·
All issues in Shopify/shopify-function-javascript
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100