Shopify/liquid

Ruby 3.3 deprecation warnings: base64, bigdecimal will no longer be part of the default gems

Open

#1,772 opened on Dec 27, 2023

View on GitHub
 (1 comment) (6 reactions) (0 assignees)Ruby (11,788 stars) (1,519 forks)batch import
Good first issuehelp wanted

Description

liquid-5.4.0/lib/liquid/standardfilters.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

/liquid-5.4.0/lib/liquid/standardfilters.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.

Since liquid does not have any dependencies in gemspec I don't feel like adding

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')
  s.add_dependency('base64')
  s.add_dependency('bigdecimal')
end

so just leave this as issue, not PR

Contributor guide

Tech stack
ruby
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ruby basicsGemfile/gemspec understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in liquid 5.4.0/lib/liquid/standardfilters.rb lines 4-5. The warnings indicate that base64 and bigdecimal need to be added as dependencies conditionally for Ruby >= 3.3. The fix would involve editing the gemspec file (e.g., liquid.gemspec) to conditionally add these dependencies using a version check like `if Gem::Version.new(RUBY VERSION) >= Gem::Version.new('3.3')`. Note that the issue author suggests not adding them by default, so a conditional approach is appropriate. Check any existing conditional dependencies in the gem.