Ability to fail the whole process if spinner fails
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Read lib/cli/ui/frame.rb at lines 127-131 to compare the existing process-halting behavior, then trace the spinner creation and failure path. Define the configuration option and verify that a failed spinner halts the process while the default behavior remains unchanged.
Written by the indexing model from the issue text.
Description
Currently, when the error is raised inside a Frame, the whole process is halt, see https://github.com/Shopify/cli-ui/blob/b9e35edf1345ab221e77097dfd0a4b9675d71636/lib/cli/ui/frame.rb#L127-L131
I would like to have a similar ability for spinners - to be able to pass some config option when creating a spinner, so that if it fails it halts the whole process. Currently, the spinner is only marked as failed and the process continues.
Are you open for such a feature? I can help with a PR.
- Dominant language
- Ruby
- Stars
- 1.1k
- Forks
- 57
- Avg merge
- 2h 55m
- Merged PRs (30d)
- 2
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Shopify/cli-ui
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
IBM/ai-security-baseline#25 ·
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Mend: dependency security vulnerability
Difficulty 2/5 1-3 hours Newbie friendliness 62/100