Vendored code gen is broken
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Run cli-kit new myapp, select the vendor method, and reproduce the LoadError when running myapp/exe/myapp. Start with vendor/deps/cli-ui/lib/cli/ui/stdout_router.rb and compare the vendored path with the bundled-gem fix referenced in cli-ui issue 418. Done means a newly generated vendored app runs without the missing reentrant_mutex error.
Written by the indexing model from the issue text.
Description
If creating a new cli app using the vendored method, cli-ui is vendored without it's own vendor directory. This issue was solved for the bundled gem here: https://github.com/Shopify/cli-ui/issues/418
Reproduction:
cli-kit new myapp
# (select vendor)
myapp/exe/myapp
/Users/brendansamek/startup/reactor/reactor/vendor/deps/cli-ui/lib/cli/ui/stdout_router.rb:6:in 'Kernel#require_relative': cannot load such file -- /Users/brendansamek/startup/reactor/reactor/vendor/deps/cli-ui/vendor/reentrant_mutex (LoadError)
from /Users/brendansamek/startup/reactor/reactor/vendor/deps/cli-ui/lib/cli/ui/stdout_router.rb:6:in '<top (required)>'
from /Users/brendansamek/startup/reactor/reactor/vendor/deps/cli-ui/lib/cli/ui.rb:359:in 'Kernel#require'
from /Users/brendansamek/startup/reactor/reactor/vendor/deps/cli-ui/lib/cli/ui.rb:359:in '<top (required)>'
from /Users/brendansamek/startup/reactor/reactor/lib/reactor.rb:1:in 'Kernel#require'
from /Users/brendansamek/startup/reactor/reactor/lib/reactor.rb:1:in '<top (required)>'
from exe/reactor:14:in 'Kernel#require'
from exe/reactor:14:in '<main>'
- Dominant language
- Ruby
- Stars
- 161
- Forks
- 16
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 5
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Shopify/cli-kit
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Similar issues
-
user-reported
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kong/developer.konghq.com#7316 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
TheOdinProject/curriculum#31408 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
notch8/utk_knapsack#148 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Homebrew/homebrew-cask#288729 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100