SheffieldML/GPy

There are `assert`s where we need `ValueError`s

Open

#922 opened on May 27, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (579 forks)batch import
good first issue

Repository metrics

Stars
 (1,927 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We should not use assert to address bad user input, but there are such uses of assert in the GPy codebase. Instead, we should use ValueError. For more details, see https://github.com/SheffieldML/GPy/pull/917#discussion_r639520080

Contributor guide

Research direction
Search for `assert` statements in the GPy codebase that validate user input, then replace them with `ValueError` exceptions.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85