SerenityOS/serenity

PR Labeler: Does not properly relablel PRs

Open

#17,271 opened on Feb 2, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,328 forks)batch import
help wantedtask list

Repository metrics

Stars
 (33,171 stars)
PR merge metrics
 (Avg merge 5d 11h) (35 merged PRs in 30d)

Description

We added the handy PR labeler CI action, but it doesn't seem to add labels properly in the following cases:

  • When a review is submitted by someone other than the author, change the state from "needs review" to "waiting for author feedback"
  • When a review is approved, move the state to "community approved" or "maintainer approved" based on who did the approval.
  • When a PR is detected to have conflicts, add the "has conflicts" label
  • When changes are pushed, remove the "waiting for author feedback" label and add "needs review"

Contributor guide

Research direction
Examine the existing PR labeler workflow YAML file (likely in .github/workflows) and identify why it fails to relabel PRs on review submission, approval, conflict detection, and push events. Then add the necessary event triggers and conditional logic to handle each case.
Tech stack
github actions
Domain
ci cd
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70