SerenityOS/serenity

PR Labeler: Does not properly relablel PRs

Open

#17,271 opened on Feb 2, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (33,171 stars) (3,328 forks)batch import
help wantedtask list

Description

We added the handy PR labeler CI action, but it doesn't seem to add labels properly in the following cases:

  • When a review is submitted by someone other than the author, change the state from "needs review" to "waiting for author feedback"
  • When a review is approved, move the state to "community approved" or "maintainer approved" based on who did the approval.
  • When a PR is detected to have conflicts, add the "has conflicts" label
  • When changes are pushed, remove the "waiting for author feedback" label and add "needs review"

Contributor guide

Tech stack
github actionsshell
Domain
ci cddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GitHub ActionsYAML scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the existing PR labeler workflow in .github/workflows. Identify the current logic for labeling based on reviews, approvals, conflicts, and pushes. Determine where the failures occur for the listed cases. Consider using a community labeler action or custom script to handle all states. Check if there are any configuration files or environment variables that control labeling behavior.
PR Labeler: Does not properly relablel PRs · SerenityOS/serenity#17271 | Good First Issue