Semantic-Org/Semantic-UI-React

bug: [Popup] doesn't take into account popper's attributes, only styles

Open

#4488 opened on Jul 24, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
buggood first issue

Description

Bug Report

state.attributes.popper aren't applied to the popup wrapper div, only state.styles.popper are.

Steps

  1. Use Popup component with default props and modifiers (which include hide by default) and on="click".
  2. Open the popup by clicking the trigger.
  3. Scroll the trigger out of the viewport.

Expected Result

The popup wrapper div gets the attributes data-popper-escaped and data-popper-reference-hidden from the default hide modifier.

Actual Result

No attributes are added to the div.

Version

2.1.5

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactPopper.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Look at the Popup component in Semantic UI React, likely in src/modules/Popup/Popup.js or similar. The popup wrapper div currently applies state.styles.popper but not state.attributes.popper. The fix involves merging attributes from state.attributes.popper into the wrapper div's props. Ensure that attributes like data popper escaped and data popper reference hidden from the hide modifier are passed to the div. Check the Popper.js documentation for how attributes are handled and verify that the default hide modifier is being used. The issue is isolated to the Popup component's rendering logic.