Semantic-Org/Semantic-UI-React

Dropdown doesn't close when placed inside of Checkbox component

Open

#4036 opened on Aug 15, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wanted

Description

Bug Report

Steps

  1. Click on dropdown
  2. Click on one of the options

Expected Result

The dropdown menu should close

Actual Result

It remains open until you click on one of the options one more time or click outside of the menu

Version

1.2.0

Testcase

https://codesandbox.io/s/vigorous-ives-l0qwm?file=/example.js

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic React knowledgeUnderstanding of event propagation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate event handling in Dropdown and Checkbox components. Look at https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Dropdown/Dropdown.js and https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Checkbox/Checkbox.js to understand click propagation. The issue may be related to event.stopPropagation() interfering with dropdown close logic. Test the behavior in the provided CodeSandbox and identify where the click event is being swallowed.