Semantic-Org/Semantic-UI-React

Popup: Incorrect position of arrow

Open

#3771 opened on Sep 2, 2019

View on GitHub
 (7 comments) (7 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wantedneeds engineering

Description

Bug Report

Steps

  1. Create an element with a popup
  2. Move that element to the right side of the page

Expected Result

I don't know an exact position of a trigger element on a page in advance but I expect popup and popup arrow will be displayed correctly everywhere as it was in 0.86.0. old

Actual Result

Popup arrow position is incorrect. The package doesn't calculate a popup position based on an actual popup trigger position. It passes down a position from props to popper and applies css styles based on that instead of calculating a correct value. In the previous version a position was changed to 'top right' but in current version it's 'top left' from defaultProps always. new

Version

0.88.0

Testcase

https://codesandbox.io/s/semantic-ui-react-o7mfd

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsCSS positioningPopup component knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The bug is in the Popup component's positioning logic. The issue provides a CodeSandbox testcase (https://codesandbox.io/s/semantic ui react o7mfd). The maintainers need to investigate why the position prop is not being recalculated based on the trigger element's actual position, as it was in version 0.86.0. Likely related files are `src/modules/Popup` and the positioning utility.