Semantic-Org/Semantic-UI-React

Tab: in vertical mode with renderActiveOnly styling broken for all content except first tab

Open

#3412 opened on Feb 2, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wantedstale

Description

Bug Report

Steps

Create a tab in vertical mode with renderActive Only set to false

import React from 'react'
import { Tab } from 'semantic-ui-react'

const panes = [
  { menuItem: 'Tab 1', pane: 'Tab 1 Content' },
  { menuItem: 'Tab 2', pane: 'Tab 2 Content' },
  { menuItem: 'Tab 3', pane: 'Tab 3 Content' },
]

const TabExampleBasicAll = () => <Tab panes={panes} menu={{vertical: true, fluid: true}} renderActiveOnly={false} />

export default TabExampleBasicAll

Expected Result

Outer box for all content items should be the same.

Actual Result

When you navigate to any item other than the first, the top border is not shown

Version

0.84.0

Testcase

https://codesandbox.io/s/825yxr5zn0

Screenshots

Contributor guide

Tech stack
javascriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactCSSSemantic UI React basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug is in the Tab component's styling when `renderActiveOnly={false}` and vertical menu. Inspect the CSS classes applied to the active and inactive tab panes. The top border is missing on non first panes. Check the Tab component's rendering logic in `src/modules/Tab/Tab.js` and associated CSS files. The testcase at https://codesandbox.io/s/825yxr5zn0 can be used to reproduce. Look for CSS rules that conditionally apply border top based on active state.