Semantic-Org/Semantic-UI-React

RFC: Popup more intuitive behavior with multiple `on` events

Open

#2765 opened on May 5, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
enhancementhelp wanted

Description

Bug Report

The problem happens when using multiple events to trigger Popup. Can be reproduced with <Popup trigger={<button>Show tooltip</button>} content='tooltip' on={['click', 'hover']} but the easiest way is with <Popup trigger={<button>Show tooltip</button>} content='tooltip' on={['click', 'focus']}. Just try clicking the button. For the first time, it opens the popup and immediately closes it. Following clicks work correctly. This problem has been mentioned in #2075 by @austinfox here.

Steps

  1. Go to Semantic UI React Popup demo.
  2. Edit e.g. first example Popup component to contain multiple on events i.e. on={['click', 'focus']}.
  3. Click the popup trigger.

Expected Result

Popup is displayed and stays open.

Actual Result

Popup is displayed and closed immediately.

Version

0.80.0

Testcase

Check the steps section above.

Contributor guide

Tech stack
javascriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React knowledgeEvent handling basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Popup component's event handling logic in the source code, specifically how it manages multiple `on` event types. Check the linked comment in issue #2075 for previous discussion. The fix likely involves ensuring that when multiple events are specified, the popup does not close immediately after opening due to event propagation or state management issues. Look at the Popup component file in the repository, possibly `src/modules/Popup/Popup.js`.