Semantic-Org/Semantic-UI-React

Support `transition` and `popup` props

Open

#2552 opened on Feb 21, 2018

View on GitHub
 (13 comments) (2 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
help wantedstale

Description

Add support for the transition prop which automatically adds a transition when a Popup is opened/closed as in SUI: https://semantic-ui.com/modules/popup.html#transitions

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React knowledgeSemantic UI React Popup component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, examine the current Popup component implementation in src/modules/Popup/Popup.js and its related files. Reference the Semantic UI documentation for transitions (https://semantic ui.com/modules/popup.html#transitions). Then, implement a `transition` prop that accepts transition name and possibly config, and wire it to the existing animation logic. Also consider handling the `popup` prop if separate. Engage with maintainers to confirm desired API if needed.