Semantic-Org/Semantic-UI-React

Rework TransitionablePortal callbacks for consistency

Open

#2423 opened on Jan 10, 2018

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wanted

Description

Steps

  1. Create a controlled <TransitionablePortal />
  2. Toggle the open prop from false to true
  3. Trigger a close with ESC or click outside

Expected Result

  1. On prop change to open, the onOpen callback should not be called. This is a programmatic prop change, not a trigger click.
  2. When a close event is triggered, the onClose callback should be called before starting the transition as the user may choose to disregard the close request.

Actual Result

  1. On prop change to open, onOpen is called at the beginning and end of the open transition
  2. When a close event is triggered, the onClose callback is called after the onHide callback. There is no way to handle the close request and ignore it.

See the test case for proposed fixes.

Version

0.77.2

Testcase

https://codesandbox.io/s/rj8qv1yl2o

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of React component lifecycleBasic knowledge of callback patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the TransitionablePortal component's source code, likely in src/modules/TransitionablePortal. Review the test case provided in the CodeSandbox to understand the current callback behavior. Check the comments on the issue for any proposed solutions or maintainer input. The goal is to reorganize when onOpen and onClose callbacks are triggered to match the expected behavior described in the issue.