Semantic-Org/Semantic-UI-React

Modal: implement focus trap

Open

#2,278 opened on Nov 1, 2017

View on GitHub
 (8 comments) (10 reactions) (0 assignees)JavaScript (4,065 forks)batch import
enhancementhelp wantedstale

Repository metrics

Stars
 (13,136 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Modal should not let focus leave the components inside the dialog. Also it should autofocus the first component in the dialog (if no autofocus was specified).

More on Modals and keyboard traps: https://developers.google.com/web/fundamentals/accessibility/focus/using-tabindex

Steps

  1. Open any modal on the example page: https://react.semantic-ui.com/modules/modal
  2. Press tab multiple times

Expected Result

Focus should never enter the dimmed components below

Actual Result

Focus does enter the dimmed components below

Version

Current Tested in Chrome Version 61.0.3163.100 (Official Build) (64-bit)

Testcase

https://react.semantic-ui.com/modules/modal

Contributor guide

Research direction
Examine the Modal component in the Semantic UI React codebase to understand its current focus behavior. Implement a focus trap that prevents focus from moving outside the modal when it is open, and ensure the first focusable element inside the modal receives focus upon opening. Use techniques like identifying focusable elements, managing tabindex on the dimmer, and handling Tab key events. Refer to the provided Google Developers article for best practices.
Tech stack
javascriptreact
Domain
frontend
Issue type
Accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReactAccessibility concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75