Semantic-Org/Semantic-UI-React

Dropdown: clicking outside vs. closing behavior

Open

#2080 opened on Sep 15, 2017

View on GitHub
 (13 comments) (1 reaction) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wanted

Description

Issue 1

  • Steps: Click on the dropdown then outside.
  • Expected Result: No option selected. Works if we close instead of clicking outside.
  • Actual Result: First option selected.

Issue 2

  • Steps: Select Item B then search for Item D (no results). Close dropdown (do not click outside).
  • Expected Result: Item B displayed.
  • Actual Result: Item D displayed. Item B is displayed back if we click outside instead.

Issue 3

  • Steps: Select Item B then search for Item D (no results). Click outside, open the dropdown and click outside once more.
  • Expected Result: Item B selected.
  • Actual Result: Item A selected.

Version

0.73.0

Testcases

https://codepen.io/anon/pen/JrdwxW

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactSemantic UI React Dropdown
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the Dropdown component implementation, likely in src/modules/Dropdown/Dropdown.js. The issue involves closing behavior and state management when clicking outside vs. programmatic close. Look at the handleClose and handleClickOutside methods. The bug seems to be that closing by clicking outside triggers a different state update than closing via the dropdown's own close mechanism. Investigate the order of state updates and the resetting of selection. Also check the test cases provided in the issue to reproduce.