Semantic-Org/Semantic-UI-React

Dropdown: incorrect focus

Open

#2,046 opened on Sep 4, 2017

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (4,065 forks)batch import
bughelp wanted

Repository metrics

Stars
 (13,136 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This applies to use in Chrome.

Testcase https://react.semantic-ui.com/modules/dropdown#dropdown-example-open-on-focus

Steps to Reproduce

  1. Click on the down arrow (NOT on the text of the drop-down) of the second dropdown
  2. Click on the down arrow again
  3. Press 'shift + tab' to navigate to the first dropdown

Expected The first dropdown should now have the focus

Result The second dropdown retains the focus.

** FIX ** This is because when clicking on the down arrow, its the <i ../> element that obtains the focus.

Applying the style pointer-events: none; to the <i .../> element resolves the issue, when the down arrow is clicked focus is passed through to the dropdown component as expected.

Contributor guide

Research direction
Apply CSS pointer events: none to the dropdown arrow icon to prevent it from capturing focus.
Tech stack
javascriptreactcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80