Semantic-Org/Semantic-UI-React

Popup: triggers that do not spread props do not work

Open

#1187 opened on Jan 19, 2017

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
enhancementhelp wanted

Description

Steps

  1. Create a stateless component.
  2. Pass it to Popup as the trigger prop.

Expected Result

Get the popup when mousing over the trigger component.

Actual Result

Don't get a popup when mousing over the trigger component.

Version

0.64.2 (master)

Testcase

http://codepen.io/anon/pen/VPpZQL

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsunderstanding of component props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug occurs when a stateless component is passed as the `trigger` prop without spreading props. Investigate the Popup component's source code (likely in `src/modules/Popup`) to see how it renders the trigger. Check if there is a missing spread of props onto the trigger element. The provided CodePen testcase can be used to replicate. Look at how similar components handle prop spreading in this codebase.