SeleniumHQ/selenium

[🚀 Feature]: Implement Navigation Commands with BiDi

Open

#13,995 opened on May 21, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Java (34,077 stars) (8,680 forks)batch import
B-devtoolsC-dotnetC-javaC-nodejsC-pyC-rbI-enhancementgood first issue

Description

Feature and motivation

Moving forward, Selenium plans to update implementations to use WebDriver BiDi instead of WebDriver Classic if BiDi is enabled.

It was decided at the Selenium Dev Summit that we would implement the navigation commands with BiDi in all the bindings as the minimum for Selenium 5. This will act as a proof of concept that a user can successfully use either BiDi or Classic depending on the capabilities that are set. We do not need to implement everything in BiDi spec before releasing Selenium 5, just have a working module as a pattern to work from.

Considerations

  • let's not worry about making sure we're storing the browser context id properly everywhere for this issue
  • we do need to make sure we're looking at the user's page load strategy to determine how to wait for the navigation

Implementations

  • .NET — #14052

Contributor guide

Tech stack
javacsharp
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of WebDriver BiDi specificationFamiliarity with Selenium's architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The .NET implementation is already in progress (#14052). For other bindings, developers should review the BiDi specification for navigation commands and follow the pattern established in the .NET PR. The implementation must consider the user's page load strategy for waiting. The browser context ID storage is not a priority. Focus on making the navigation work with BiDi when enabled.