Iris changes bypass `Nc4DatasetLike.filepath()`

Open
#132 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Review SciTools/iris@03a5e72 and compare Nc4DatasetLike.filepath() with Nc4VariableLike.group(), whose result is represented by NcData. Check SciTools/iris#6495 and #122 before changing anything; done means the filepath acquisition path remains consistent if this issue is still necessary.

Written by the indexing model from the issue text.

Description

The change: SciTools/iris@03a5e72

Before/After How Iris acquires the NetCDF file name
Before the change Dataset.filepath() exclusively
After the change Also Variable.group().filepath() [^1]
Approach Class that represents dataset Class implements .filepath()?
to_iris() Nc4DatasetLike Yes ✔
Nc4VariableLike.group() NcData No ❌

A fix is not urgent, as this is de-risked by SciTools/iris#6495. And a fix might be made unnecessary by #122?

[^1]: .group() returns the Dataset

Dominant language
Python
Stars
16
Forks
5
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SciTools/ncdata

All issues in SciTools/ncdata

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.