SalesforceCommerceCloud/pwa-kit

[BUG] Uncaught exception when adding a number of items to cart larger than the available stock

Open

#388 opened on Feb 8, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (234 forks)github user discovery
Acknowledgedgood first issue

Repository metrics

Stars
 (359 stars)
PR merge metrics
 (Avg merge 2d 11h) (38 merged PRs in 30d)

Description

Summary

The useBasket hook throw an exception when a shopper tries to add more products to their cart than is available in stock.

useBasket.js:51 Uncaught (in promise) Error: [object Object] at useBasket.js:51

This is because we're not handling the API response with the exception type ProductItemNotAvailableException:

{"_v":"21.3","fault":{"arguments":{"productId":"701642842637M","quantity":110.0},"type":"ProductItemNotAvailableException","message":"The product '701642842637M' isn't available for quantity '110'."}}

Steps To Reproduce

  • Navigate to the PDP of any product.
  • Set quantity to 99 and repeatedly click the Add to cart button until the exception is thrown.

Expected result

The user is shown a useful error saying that the item is not available at the requested quantity.

Actual result

A Something went wrong Try again! popup appears. A 400 error appears in the devtools console.

@ W-9231893 @

Contributor guide

Research direction
Handle the ProductItemNotAvailableException from the API response in the useBasket hook to display a user friendly error message instead of an uncaught exception.
Tech stack
javascriptreact
Domain
frontendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70