SSENSE/vue-carousel

Feature Request: add server side rendering (Nuxt.js) to vue-carousel

Open

#81 opened on Aug 29, 2017

View on GitHub
 (37 comments) (7 reactions) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
featurehelp wanted

Description

Newbie. I had vue-carousel running great prior to an update, in nuxt I think. Now it simply won't work.

Running vue-carousel locally in component, Terminal: `[Vue warn]: Error in beforeCreate hook: "ReferenceError: document is not defined"

found in

---> at components/CarouselShow.vue <Pages/index.vue> at pages/index.vue at .nuxt/components/nuxt.vue at layouts/default.vue

` And I guess it is in a loop, because Chrome keeps spinning and eventually I get the dialog box "Do you wish to kill process?"

If I run vue-carousel globally I do not get the warning, but my Slides are static and all Slides show up on the page at once.

Help much appreciated.

Contributor guide

Tech stack
javascriptvuenuxt
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Vue.js basicsNuxt.js basicsUnderstanding of SSR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The error is due to using `document` in Vue lifecycle hooks that run on the server. To fix, the component must check for browser environment or use client only rendering. The issue comments may have discussed workarounds. Look into using `process.client` in Nuxt or wrapping the component in `<client only>`. Also consider making the carousel import dynamic with `ssr: false`.