SSENSE/vue-carousel

Feature request: Use style classes instead of inline styles

Open

#48 opened on Apr 19, 2017

View on GitHub
 (4 comments) (11 reactions) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
featurehelp wanted

Description

There're a few component options regarding styles such as paginationActiveColor, paginationPadding, etc. Since they are rendered as inline styles, it is hard to override them with CSS classes. It's better to set CSS classed for these elements. What do you think?

Contributor guide

Tech stack
vuejavascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic VueCSS knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the current implementation of the carousel component, likely in a .vue file. Identify all props like `paginationActiveColor`, `paginationPadding` that set inline styles. Propose a mapping to CSS classes and consider how to allow user overrides. Review any existing comments or linked issues for design preferences.