SSENSE/vue-carousel

Bug: Adjustable height is broken on both Firefox and IE11

Open

#412 opened on Mar 29, 2019

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
buggood first issuehelp wanted

Description

Bug Report

Current Behavior When using adjustable height, Firefox seems to present the carousel as having a height of only 48. If you click on the carousel after it loads, it will instantly resize to the proper height.

Input Code and steps to reproduce

  • set :adjustableHeight="true"
  • refresh

Expected behavior/code The carousel height should initialize at the height of the first item. It works in Chrome but in FF/IE11 it initializes at 24 or 48 height.

Environment

  • Browsers: Firefox / IE11
  • OS: OSX 10.14.3

Possible Solution After debugging it looks like it has something to do with getCarouselHeight().

Contributor guide

Tech stack
vuejavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue basicsbrowser debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the `getCarouselHeight()` function in the Vue carousel component to understand how it calculates height on initial load. Use browser dev tools to compare behavior in Chrome vs Firefox/IE11. The issue notes that clicking after load fixes the height, suggesting a timing or rendering issue. Check if there are any differences in how the browser reports element dimensions when the component mounts.