SSENSE/vue-carousel

Bug: pageChange event gives NaN sometimes with mouse drag

Open

#408 opened on Mar 26, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
buggood first issuehelp wanted

Description

Bug Report

Current Behavior On mouse drag on the last slide, sometimes pageChange event gives NaN while remaining on the same slide where mouse was dragged upon and after that carousel becomes non-operational on mouse drag(slides do not move at all).

Did not face this issue with custom navigation buttons however.

Input Code and steps to reproduce Attaching screenshot of console log, where pageChange event handler logs the page number.

Screen Shot 2019-03-26 at 6 51 42 PM

Expected behavior/code pageChange event shouldn't be triggered, if there is no slide change at all.

Babel Configuration (.babelrc, package.json, cli command)

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Vue.js knowledgeUnderstanding of mouse eventsCarousel component logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the pageChange event emission in the carousel component. The issue occurs during mouse drag on the last slide. Review the drag handling logic and ensure that the page index is only emitted when a slide change occurs, not on every drag movement. Check the calculation of the page index to prevent NaN values. Look at the component's event handlers and the page update mechanism in files like Carousel.vue or similar.