SSENSE/vue-carousel

pagination buttons missing type attr gets interpreted as submit-btn

Open

#386 opened on Mar 12, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,705 stars) (513 forks)batch import
buggood first issuehelp wanted

Description

pagination buttons missing type attr gets interpreted as submit-btn

on clicking pagination a request gets sent to server. This is because type attribute is not set on dot-buttons and browser interprets it as a submit button.

Contributor guide

Tech stack
vuejavascripthtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HTMLVue.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is about pagination dot buttons missing the type attribute. In the Vue component template, likely in 'Carousel.vue' or 'Pagination.vue', locate the button elements used for pagination dots. Add type="button" to each button element to prevent them from being treated as submit buttons when inside a form. No other changes are needed.